Include -isysroot linker arg on macos #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds -isysroot linker flag when building extensions on darwin target.
Uses
xcrun --show-sdk-path
to determine isysroot value.This is a minimal patch that allows building
lxml
on MacOS Sierra 10.12.x with XCode 9.Based on suggestions found in https://forums.developer.apple.com/thread/87829
and addresses https://bugs.launchpad.net/lxml/+bug/1727864