New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline_style option #180

Merged
merged 2 commits into from Jul 24, 2016

Conversation

Projects
None yet
2 participants
@chripede
Contributor

chripede commented Nov 19, 2015

Currently the style option will remove both style tags and attributes.
This change makes each an option, just like scripts and javascript.

Add inline_style option
Currently the style option will remove both style tags and attributes. 
This change makes each an option, just like scripts and javascript.
@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Nov 19, 2015

Member

This breaks both the API and a test. And it adds a new option without testing it. No way I can accept that.

Member

scoder commented Nov 19, 2015

This breaks both the API and a test. And it adds a new option without testing it. No way I can accept that.

@chripede

This comment has been minimized.

Show comment
Hide comment
@chripede

chripede Nov 20, 2015

Contributor

Was in a hurry and forgot the tests. I fixed the broken one and added a new one.

Contributor

chripede commented Nov 20, 2015

Was in a hurry and forgot the tests. I fixed the broken one and added a new one.

@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Nov 20, 2015

Member

It still breaks the API, though. If you want a new option for such a special case, it shouldn't break all code out there. It should just be a new option.

Member

scoder commented Nov 20, 2015

It still breaks the API, though. If you want a new option for such a special case, it shouldn't break all code out there. It should just be a new option.

@chripede

This comment has been minimized.

Show comment
Hide comment
@chripede

chripede Dec 4, 2015

Contributor

So in order to not break the API, should I move the inline_style into the style and default inline_style to True?

Contributor

chripede commented Dec 4, 2015

So in order to not break the API, should I move the inline_style into the style and default inline_style to True?

@scoder scoder merged commit 0a43d0b into lxml:master Jul 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Jul 24, 2016

Member

I think they should be separate options where the new one falls back to the old one if not provided. d3b73e5

Member

scoder commented Jul 24, 2016

I think they should be separate options where the new one falls back to the old one if not provided. d3b73e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment