External cssselect #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes ugly hack to support Python 2.4
translator defaults to 'xml' in _Element and 'html' in HtmlElement
No need to duplicate the tests that are now in cssselect. Now test_css.py only tests what is specific to lxml.
|
By the way, cssselect v0.5+ is required for |
This is an addition to the API that should be considered separatly from using the new cssselect. This reverts commit 7820b8d.
Closed
|
Looks good. Thanks for all the work! |
This was referenced Apr 23, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch removes most of lxml.cssselect and uses the new cssselect project to provide the same functionality.
The new project distinguishes "generic" XML (no assumption is made on the meaning of element names) and HTML (has a more useful implementation of some pseudo-classes like
:linkor:checked.) This, theCSSSelectclass as well as thecssselectmethod now have atranslatorargument that can be 'xml', 'html, 'xhtml', or a Translator object. (See the documentation.) The translator default to 'html' on HtmlElement.cssselect, 'xml' everywhere else.The dependency is optional, so importing lxml.cssselect or calling the cssselect() method of elements can cause an ImportError at runtime.
I believe this fixes issues #34, #40, and #41.
#45 is partially addressed: all elements now have a
cssselectmethod. However, html5parser still does not make HtmlElement objects so the user may need to passtranslator='html'explicitly.#20 is not resolved yet, but cssselect’s #3 is open about the same issue.
cssselect still has a few unresolved issues (filed on github), but the API should be stable now.