Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainWindow: fix ignore WM_SIZE causes statusbar invisible when created #747

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

evangwt
Copy link
Contributor

@evangwt evangwt commented Dec 12, 2020

Fix this issue

As @jackyzy823 mentioned that this commit introduced the bug. And I find this line is the key.

Here are some additional remark from MSDN doc

By default, the DefWindowProc function sends the WM_SIZE and WM_MOVE messages to the window. The WM_SIZE and WM_MOVE messages are not sent if an application handles the WM_WINDOWPOSCHANGED message without calling DefWindowProc. It is more efficient to perform any move or size change processing during the WM_WINDOWPOSCHANGED message without calling DefWindowProc.

@alkanna
Copy link

alkanna commented Jan 10, 2021

This should be merged, it's working without any issues atm.

@alkanna
Copy link

alkanna commented Jan 11, 2021

Ping @lxn

@lxn
Copy link
Owner

lxn commented Jan 11, 2021

Please add yourself to the AUTHORS file, then this can be merged.

@alkanna
Copy link

alkanna commented Jan 11, 2021

@evangwt

@evangwt
Copy link
Contributor Author

evangwt commented Jan 12, 2021

Please add yourself to the AUTHORS file, then this can be merged.

Thanks for your review, AUTHORS is updated ;)

@lxn lxn merged commit c389da5 into lxn:master Jan 12, 2021
@lxn
Copy link
Owner

lxn commented Jan 12, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants