notifyicon: recreate when explorer.exe crashes #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [1], we receive a TaskbarCreated message after Windows recreates the taskbar, which can happen if explorer.exe crashes or even if the DPI changes. When this happens, we're supposed to create a new notify icon; otherwise the previous one is nowhere to be found. This commit listens for that message and recreates the state accordingly. [1] https://docs.microsoft.com/en-us/windows/win32/shell/taskbar?redirectedfrom=MSDN#taskbar-creation-notification Reported-by: Riccardo Paolo Bestetti <pbl@bestov.io> Diagnosed-by: Simon Rozman <simon@rozman.si>
zx2c4
force-pushed
the
jd/recreate-tray
branch
from
506862d
to
874f348
Compare
|
Ping @lxn |
|
Oh, nice - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MSDN, we receive a TaskbarCreated message after Windows recreates the taskbar, which can happen if explorer.exe crashes or even if the DPI changes. When this happens, we're supposed to create a new notify icon; otherwise the previous one is nowhere to be found. This commit listens for that message and recreates the state accordingly.
Reported-by: @vmsh0
Diagnosed-by: @rozmansi