Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate side-pane's focused item on pressing Enter/Return #525

Merged
merged 1 commit into from Feb 22, 2020

Conversation

tsujan
Copy link
Member

@tsujan tsujan commented Feb 16, 2020

This is needed only rarely because the side-pane usually doesn't have focus. But it's an expected behavior.

Closes #524

This is needed only rarely because the side-pane usually doesn't have focus. But it's an expected behavior.

Closes #524
tsujan added a commit to lxqt/pcmanfm-qt that referenced this pull request Feb 16, 2020
Good with keyboard-only navigation. `Esc` is already used to focus the view, so `Ctrl+Esc` seems good to focus the side-pane.

Relies on lxqt/libfm-qt#525

Closes #1076
@agaida agaida added this to Need Approve in Pull Requests Feb 16, 2020
@agaida agaida merged commit eb82145 into master Feb 22, 2020
@agaida agaida deleted the enter_activates_side_pane branch February 22, 2020 17:40
Pull Requests automation moved this from Need Approve to Done Feb 22, 2020
agaida pushed a commit to lxqt/pcmanfm-qt that referenced this pull request Feb 22, 2020
Good with keyboard-only navigation. `Esc` is already used to focus the view, so `Ctrl+Esc` seems good to focus the side-pane.

Relies on lxqt/libfm-qt#525

Closes #1076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Pull Requests
  
Done
Development

Successfully merging this pull request may close these issues.

Open side pane items by pressing Enter/Return (when they have focus)
2 participants