appchooser: don't disable the OK button #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsujan
reviewed
Dec 11, 2022
When we are not in the app view tab, don't change the enable state of the OK button; the selection may be reset by the menu-cache.
kreijack
force-pushed
the
appchooser-ok-btn
branch
from
9935db8
to
8d6feea
Compare
|
Hi I updated the comment as per request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are not in the app view tab don't change the enable state of the OK button, only because we lost the focus from the app on the app view.
In the appchooser dialog, sometime we loose the active status of the OK button in the "custom command" tab.
This happens because if in the "Installed Application" tab the selection is lost, then the "OK button enable status" is disabled.
This patch ensures that the OK button state is changed only when the "Installed Application" tab is shown.