Those changes solves memory leak in backlight brightness driver.

lxqt · Apr 7, 2020 · 00a3949 · 00a3949
1 parent 75de052
commit 00a3949
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/lxqtbacklight/linux_backend/linuxbackend.cpp b/lxqtbacklight/linux_backend/linuxbackend.cpp
@@ -51,7 +51,7 @@ LinuxBackend::LinuxBackend(QObject *parent):VirtualBackEnd(parent)
 
 LinuxBackend::~LinuxBackend()
 {
-    delete backlightStream;
+    closeBacklightStream();
 }
 
 int LinuxBackend::getBacklight()
@@ -80,20 +80,24 @@ void LinuxBackend::setBacklight(int value)
     if( ! isBacklightAvailable() )
         return;
     if( backlightStream == NULL ) {
-        FILE *stream = lxqt_backlight_backend_get_write_stream();
-        backlightStream = new QTextStream(stream);
-        // Close stream after 60 seconds
-        QTimer::singleShot(60000, this, SLOT(closeBacklightStream()));
+        backlightStream = lxqt_backlight_backend_get_write_stream();
+        if( backlightStream != NULL ) {
+            // Close stream after 60 seconds
+            QTimer::singleShot(60000, this, SLOT(closeBacklightStream()));
+        }
+    }
+    if( backlightStream != NULL ) {
+        // normalize the value (to work around an issue in QSlider)
+        value = qBound(0, value, maxBacklight);
+        fprintf(backlightStream, "%d\n", value);
+        fflush(backlightStream);
     }
-    // normalize the value (to work around an issue in QSlider)
-    value = qBound(0, value, maxBacklight);
-    *backlightStream << value << endl;
 }
 
 void LinuxBackend::closeBacklightStream()
 {
     if( backlightStream != NULL ) {
-        delete backlightStream;
+        fclose(backlightStream);
         backlightStream = NULL;
     }
 }

diff --git a/lxqtbacklight/linux_backend/linuxbackend.h b/lxqtbacklight/linux_backend/linuxbackend.h
@@ -44,10 +44,10 @@ private Q_SLOTS:
     void fileSystemChanged(const QString & path);
 
 private:
-    QTextStream *backlightStream;
     int maxBacklight;
     int actualBacklight;
     QFileSystemWatcher *fileSystemWatcher;
+    FILE *backlightStream;
 };
 
 } // namespace LXQt