New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made directories under "Technical Info" clickable #239
Conversation
Only if they exist. Closes #238
Any objection to merging? |
Thanks!
Although the patch version of LXQt About doesn't seem important, suppose there's a critical bug in its version 1.2.0 (very unlikely but we're fallible human beings). Then, we don't want to change the version of LXQt because of that; we just want to release the fixed LXQt-About 1.2.1. That's like other components. |
But who cares of the version of LXQt-about at all? It isn't involved in any other components. So we should include all components versions following this logic. |
In the unlikely case of a critical bug, it makes sense (dev asks user, "Do you have lxqt-about 1.2.1 or the buggy 1.2.0?"). |
Oh, we already do; don't we? |
For example, see the main In |
We had LXQt 1.0 with lxqt-session 1.0.1 if I remember well |
I wonder why |
No idea, I thought it was default as one of the 3 dirs which will be read, in order. Checked in my Virtualbox installations, it's included too, so yes. You don't have it? |
No, I don't. Frankly, I haven't had time to check it. Logically, it's expected that LXQt apps that don't depend on LXQt (like pcmanfm-qt) shouldn't use it, but apps like lxqt-panel should. Doesn't lxqt-panel give priority to that folder for loading its translations? Have you tested? |
I remember that it worked for all lxqt components but not apps. I checked now my ubuntu VM and there I see twice /usr/share/lxqt/translation, while in the debian VM it was the same as in arch on the laptop and in debian on my PC, order is ~/.local - /usr/local/share ./usr/share as it should be. |
So, everything may be OK. Most probably, those LXQt apps didn't depend on LXQt.
Probably a path is added twice by the system/user there. If it happens frequently, we could remove duplicates in lxqt-about. |
Usually it adds all 3 paths, independently of existing or not. Didn't look at the code though. |
The code uses liblxqt's |
Any idea why you don't have the ~/.local one? |
You mean Actually, I don't have |
I meant "why don't you have it listed". |
I do:
lxqt-about lists the paths that EDIT: When I said, "I don't have EDIT1: Apparently, my words were confusing (the existence of folders vs. being in the list). |
I misunderstood that it wasn't listed indeed, so much do about nothing here ;) |
Only if they exist.
Closes #238