Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support viewing (launching) current item #10

Merged
merged 2 commits into from Jul 21, 2018
Merged

Conversation

tsujan
Copy link
Member

@tsujan tsujan commented Jul 3, 2018

By double-clicking it or through its context menu item if it's a file.

Also, remember the last dir on opening files in eaach session.

Also, set Qt::AA_UseHighDpiPixmaps.

Also, commented out QDebug messages to be able to see temporary ones ;)

By double-clicking it or through its context menu item if it's a file.

Also, remember the last dir on opening files in eaach session.

Also, set `Qt::AA_UseHighDpiPixmaps`.

Also, commented out `QDebug` messages to be able to see temporary ones ;)
@tsujan tsujan requested a review from PCMan July 3, 2018 10:08
@agaida agaida added this to Review Needed / Acked PRs in Pull Requests Jul 3, 2018
@agaida
Copy link
Member

agaida commented Jul 3, 2018

Works fine for me - but an additional entry "Open with ..." would be nice too. Example: *.svg - one might want to use inkscape or a simple text editor

@tsujan
Copy link
Member Author

tsujan commented Jul 3, 2018

@agaida What you want is quite valid. Currently, it uses the default app that's assigned to the mime-type. However, when item DND is implemented, the item could be dropped anywhere without further extraction because it's already extracted (in /tmp and temporarily).

That being said, I'll think about "Open with ..." later -- not for this PR.

@tsujan
Copy link
Member Author

tsujan commented Jul 3, 2018

Oh, with the kind of DND I have in mind, the item can be dropped into text editor too -- it's not like engrampa but like Arqiver.

@agaida
Copy link
Member

agaida commented Jul 4, 2018

I'm fine with - but we should not forget

@tsujan
Copy link
Member Author

tsujan commented Jul 4, 2018

but we should not forget

I won't but, for now, there are more important features to implement and bugs to fix. For example, when the header of a 7z archive is encrypted, lxqt-archiver can't open it although it's equipped with the required tools (that may be easy to fix); encrypted files don't have any emblem to show that they're password protected; 7z archives containing files with different passwords aren't well supported; etc.

I think, with the clean code @PCMan has written, no problem should be hard to fix -- I just hope I won't make his code untidy.

@agaida agaida moved this from New / ToDo to Need Approve in Pull Requests Jul 17, 2018
@agaida agaida merged commit fb8cefd into master Jul 21, 2018
Pull Requests automation moved this from Need Approve to Done Jul 21, 2018
@agaida agaida deleted the view_current_item branch July 21, 2018 17:02
lubuntu-lugito pushed a commit to lubuntu-team/lxqt-archiver-packaging that referenced this pull request Oct 6, 2018
@agaida agaida added this to Done in PRs Nov 4, 2018
@agaida agaida moved this from Done to Archive in Pull Requests Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PRs
  
Done
Pull Requests
  
Old Archive (fucked up)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants