Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomCommand: Allow plugin to expand to all rows in the panel + fixes #1712

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elviosak
Copy link
Contributor

@elviosak elviosak commented Feb 2, 2022

  • Added option to expand to all panel rows (only has effect when panel has more than 1 row). Default off, same behavior as before.
  • Correctly calculate "max width" when panel is vertical and auto rotate is off (text is horizontal and height will be limited by "max width" from config)
  • Removed ProxyStyle, was being used for right eliding text, but it is unnecessary and was preventing multi line output. (Could be re-added if the default middle eliding is annoying, or i can change to just clip the extra text instead of right eliding)
  • Reduced button updates during plugin creation and settingsChanged() or when command finishes (if text size doesn't change it won't update the dimensions)

Example with vertical panel with 2 rows and some plugins:
cmd-expand

@tsujan
Copy link
Member

tsujan commented Mar 15, 2022

Please rebase. LXQtCustomCommandConfiguration is cleaned up to conform to other plugins (after recent changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants