Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style to more plugins in KDE-Plasma theme #120

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

isf63
Copy link
Contributor

@isf63 isf63 commented Apr 17, 2024

  • Adds top bar styling to Color Picker, and Status Notifier items

The top bar on Color Picker is not positioned correctly but lxqt/lxqt-panel#2049 corrects that.

@stefonarch
Copy link
Member

stefonarch commented Apr 26, 2024

It looks ok, but for the notification area I'm unsure if we should really change a long standing theme, user might not like a change. Usually icons in notification area have no visible hover effect, expect tooltips ofc.

Afaik @yan12125 uses it, let's here others.

@yan12125
Copy link
Member

Thanks for the work. It seems this change brings more benefits (easier to identify the target QToolButton) than issues (additional margin may require reorganizing the panel layout). Overall, I'm fine with this change.

user might not like a change

I'm against a breaking change like #69. This pull request is okay :)

PS. I don't use the color picker. Only status notifiers are tested.

@isf63
Copy link
Contributor Author

isf63 commented Apr 27, 2024

Thanks for reviewing!

I don't use the color picker.

For ColorPicker and Backlight, there exists a bug when panel size is greater than the icon size on several themes, which affects this styling on KDE-Plasma. I mentioned another PR that I think is the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants