Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added palettes for suitable themes #51

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Added palettes for suitable themes #51

merged 3 commits into from
Mar 15, 2022

Conversation

stefonarch
Copy link
Member

Related to #50 which could be integrated after.

@tsujan
Copy link
Member

tsujan commented Dec 12, 2021

The installation path is correct.

There's only a small thing that needs a short story:

Ambiance was inspired by a an old GTK theme with the same name in Ubuntu. It doesn't exist anymore but was a light theme.

Kvantum has a light theme called "KvAmbiance" (different from "KvAmbience") which matches it exactly and was made for use under Unity. Since Gnome devs wanted a monopoly on GTK themes, they made theme making harder and harder. So, Ambiance became impossible after a while.

EDIT:

base_color=#ffffff, window_color=#f2f1f0, highlight_color=#f07746, etc.

@stefonarch
Copy link
Member Author

So what do you mean with this? We shouldn't add a ambiance palette but we have an "ambiance" theme?

@tsujan
Copy link
Member

tsujan commented Dec 17, 2021

No. I just mean Ambiance is a light theme, with the above-mentioned colors. It fits the dark Ambiance LXQt style (→ screenshots of old versions of Ubuntu).

@stefonarch
Copy link
Member Author

Ok, thanks,got it now.
I just took menu (background)colors for window colors.
But as things evolve: we could have "ambiance bright" and "ambiance dark"?

@tsujan
Copy link
Member

tsujan commented Dec 17, 2021

Ambiance had dark menus and light windows. It was a dark-and-light theme.

Qt palettes can't support dark-and-light themes but Qt styles can (as far as I know, only Kvantum does). This is how Ubuntu's Ambiance looked like:

ambiance

@stefonarch
Copy link
Member Author

We should finish this here. I was thinking - if doable - about an checkbox "Set also matching color scheme" in themes settings.
https://www.reddit.com/r/LXQt/comments/tb6u6o/dark_theme/

@tsujan
Copy link
Member

tsujan commented Mar 12, 2022

That reddit page is about what the user calls "color profile". Either he has an outdated version of LXQt or he hasn't launched the config dialog — most probably, the first.

@tsujan
Copy link
Member

tsujan commented Mar 15, 2022

There's a merge conflict. Would you fix it?

@tsujan
Copy link
Member

tsujan commented Mar 15, 2022

If it has passed your tests and you don't have a plan to change it, please merge it. We could enhance it later if needed.

Hopefully, I'll remember what minor problem I saw in some Panel themes and fix it.

@stefonarch stefonarch merged commit 8119db5 into master Mar 15, 2022
@stefonarch
Copy link
Member Author

Tested on my other PC, some link colors could be improved.

@stefonarch stefonarch deleted the add_palettes branch March 23, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants