No action shortcut is shown on non-menubar menus with Qt 5.10

[tsujan]

As the title says: With Qt 5.10, action shortcuts aren't shown on menus anymore, unless they are menubar menus. For example, if the menubar of pcmanfm-qt is hidden, there are no action shortcuts on menus of the menu-button. Or if the view of Kate/FeatherPad/Qt Creator is right clicked, no shortcut is shown on the context menu.

Apparently, it makes no difference whether the Qt5 app is recompiled against Qt 5.10 or not.

And why did I report this here? Because it doesn't happen under KDE!! I have no idea about the cause of this magic.

[tsujan]

Ah, found the son of a... This was the silliest change in Qt ever! Under LXQtPlatformTheme::themeHint(), this should be added for Qt-5.10:

    case QPlatformTheme::ShowShortcutsInContextMenus:
        return QVariant(true);

The ridiculous thing is that QPlatformTheme::ShowShortcutsInContextMenus should be only for context menus. Do Qt devs see all non-menubar menus as context menus now?!

EDIT: See http://doc.qt.io/qt-5/qstylehints.html#showShortcutsInContextMenus-prop.

[tsujan]

Off topic but related:

Quoting the commit message of https://codereview.qt-project.org/#/c/141647/:

"... Windows and GNOME desktop environments almost never use them. Only KDE appears to do so commonly; default accordingly."

IMO, in the long run, it won't be good if Qt devs think that it's enough to consider only Gnome and KDE on Linux.