Scrollbar appears in lxqt-config-appearence

[stefonarch]

With recent changes (introducing gtk-styles settings) there is now a scrollbar present in the left sidebar menu. Not sure if this affects all languages/systems.

Possible Solution

Increase window height slightly. I didn't find the file...

[tsujan]

Adjusting the height/width with respect to a special font/icon size or style is never a good practice. The scroll-bar is a valid part of every GUI -- you shouldn't be frightened by it ;)

[stefonarch]

Well I'm not frightened that's not the problem ;)
The scrollbar here appears for all fonts bigger as 9px the same way, cutting of only a small part at the bottom.
If changing a default window size adding only 5px can avoid it... it's not even needed...

[tsujan]

Generally, it's wrong to avoid scrollbars in the code -- it isn't really possible and any attempt can make the window too wide/tall for some.

If changing a default window size adding only 5px can avoid it

In your case. 5px, 4px,... all are wrong in the code. Qt designer sets the window width and height depending on who has used it first and with which font/style/icon sizes; even those dimensions may need to be decreased manually.

Last but not least, there's a reason that all toolkits have srollbars.

[Vladimir-csp]

Not about scrollbar, but I generally find the left pane in lxqt-config components always way too narrow. If its width is governed by some coefficient, could said coefficient be increased a bit?

[tsujan]

The width is what's needed for showing the text and icon. But we may want a parameter to tell the code about the wrapping position, so that, for example, "Icons Theme" is drawn on a single line but "Icons Theme Is Beautiful" is drawn on 2 lines. It isn't urgent though.

[agaida]

We could make it wider without problems - would look better even with the short englisch texts - i remember an open bug by PcMan about.

EDIT: found it - #1510
Trying to use nice words: It looks horrible, we should do something about.

[Vladimir-csp]

Also keep in mind that other l10ns may have more lengthy labels.

[tsujan]

We could make it wider without problems

Yes, I think so but I still don't know how easy it might be. A reasonable number of characters should be chosen. I think we could find the number in libfm-qt (although it isn't related to that dialog at all).

[tsujan]

Oh, #1510 shows we're dealing with a real bug here (I didn't know that). A fix may be somehow urgent.

[tsujan]

Found the cause; will try to fix it later.

[tsujan]

OK, I set the max number of characters to ~13 (as in libfm-qt) and got this, which looks better:

I don't know how it will look with German or Chinese but using an empty QRect in liblxqt → PageSelectWidget::updateMaxTextWidt() was the cause. Is 13 enough or should it be more?

EDIT: Corrected the height too.

[tsujan]

Please test lxqt/liblxqt#185 with your language!

[stefonarch]

Perfect now :)

[tsujan]

@stefonarch Thanks! So, 13 is enough.