-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building from source creates unusable .desktop file when grep 2.23 is installed. #957
Comments
@styrsven please, confirm that the lxqt/liblxqt@082321a fixes this issue on your side. |
Thanks, this fixed the issue for everything that depends on liblxqt. I guess this affects everything that have private copies of LXQtTranslateDesktop.cmake as well. |
👍 We need and use this patch in Fedora, too. |
Just remember there are separate copies of the file in compton.conf, libfm-qt, lximage-qt, obconf-qt and pcmanfm-qt. They need also to be updated. |
@jleclanche @PCMan @luis-pereira @paulolieuthier @tsujan |
Only lximage-qt. The others should keep lxqt-independent, AFAIK. |
Alright, I'm OK with build-dependency. |
Just in case someone stumbles upon this issue via searches or so: |
Why is this still open? |
@palinek - i guess because of the build dependency thing - we should talk about after the release |
When grep 2.22 is installed the .desktop files are created correctly.
This has been discovered on a gentoo system, and found in at least
lxqt-base/lxqt-common-0.10.0
lxqt-base/lxqt-panel-0.10.0
x11-misc/pcmanfm-qt.0.10.0
x11-misc/obconf-qt-0.9.0_p20150729
lxqt-base/lxqt-session-0.10.0
lxqt-base/lxqt-config-0.10.0
lxqt-base/lxqt-powermanagement-0.10.0
lxqt-base/lxqt-notificationd-0.10.0
lxqt-base/lxqt-globalkeys-0.10.0
lxqt-base/lxqt-admin-0.10.0
lxqt-base/lxqt-about-0.10.0
I've attached samples showing bad (with grep 2.23) and good (with grep 2.22)
lxqt-desktop.desktop.bad.txt
lxqt-desktop.desktop.good.txt
The text was updated successfully, but these errors were encountered: