Make custom pos checkbox work for multiple items #499
Conversation
Fixes #498. The state of the "Stick to current position" checkbox is corrected for multiple selections. Also when multiplely selected desktop items are right-clicked and the box is checked, all of them stick to their positions; if the box is unchecked, all of them will be sorted according to the sorting order.
Fixes (a part of) #500. For a more natural "desk-top" experience, dropped items are positioned successively (top→bottom + left→right), starting with the drop position (rectangle). IMO, there's no need to make this optional because mose users expect such a behavior and if a user doesn't want it, he/she could use the context menu easily (see #499).
Fixes (a part of) #500. For a more natural "desk-top" experience, dropped items are positioned successively (top→bottom + left→right), starting with the drop position (rectangle). IMO, there's no need to make this optional because most users expect such a behavior and if a user doesn't want it, he/she could use the context menu easily (see #499).
There was a problem hiding this comment.
ok, works as expected - but i still think we should have an option to fix all objects in the settings - it look strange when some objects are not fixed. https://youtu.be/ihvDaVvhsEo
|
@agaida There are some items that have custom positions. When you right click one of them, "Stick to Current Position" is checked. Other items don't have custom positions but are placed according to the sorting method. For them, the checkbox in question isn't checked, of course. Previous to this PR, when you right-clicked multiple items and checked/unchecked the box, they wouldn't all get/lose fixed positions -- it worked only with a single item. That was definitely a bug, which is fixed by this PR. EDIT: Corrected the last paragraph. |
|
@agaida |
|
Yet another explanation regarding your screen-cast: When you copy items to desktop, they don't have custom positions yet, so they're positioned according to the sorting order. The case of drag-n-drop was different, so I made #504 for it. BTW, I have a fix for those ugly item jumps that can be seen in your screen-cast too. Waiting for these PRs to be merged because I hate unneeded rebasing ;) |
Fixes (a part of) #500. For a more natural "desk-top" experience, dropped items are positioned successively (top→bottom + left→right), starting with the drop position (rectangle). IMO, there's no need to make this optional because most users expect such a behavior and if a user doesn't want it, he/she could use the context menu easily (see #499).
Fixes #498.
The state of the "Stick to current position" checkbox is corrected for multiple selections. Also when multiplely selected desktop items are right-clicked and the box is checked, all of them stick to their positions; if the box is unchecked, all of them will be sorted according to the sorting order.