Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schedstat optimization, it is unreliable #445

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

fastcat
Copy link
Contributor

@fastcat fastcat commented Jul 31, 2023

fixes: #444

@tsujan
Copy link
Member

tsujan commented Aug 30, 2023

You mean that the issue described in #444 is because of the following condition?

        if ((sbuf = read_proc_file2(path, "schedstat")) == nullptr)
            return -1;

I think the patch makes sense, but it should be investigated thoroughly.

It may also be related to #447.

@fastcat
Copy link
Contributor Author

fastcat commented Aug 30, 2023

You mean that the issue described in #444 is because of the following condition?

Yes.

I think the patch makes sense, but it should be investigated thoroughly.

I agree it seems strange, but I checked my systems and the contents of schedstat just ... don't change very often for some processes, even though they are consuming CPU time, etc.

It may also be related to #447.

That issue does match the symptoms I saw in #444 and applying this patch makes them go away for me, yes.

Copy link
Member

@tsujan tsujan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me. If a problem arises, we could reverse or change it.

Thanks!

@tsujan tsujan merged commit feb15b6 into lxqt:master Sep 1, 2023
@fastcat fastcat deleted the remove-schedstat branch November 27, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skipping updates if /proc/pid/schedstat doesn't change seems bad
2 participants