Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typesVersions path mapping #6

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Fix typesVersions path mapping #6

merged 1 commit into from
Aug 6, 2022

Conversation

hasali19
Copy link
Contributor

@hasali19 hasali19 commented Aug 6, 2022

Thanks for this awesome library!

I've been running into an issue where vscode adds auto-imports like import { css } from 'solid-styled/*' instead of import { css } from 'solid-styled'. This change seems to fix it.

@lxsmnsyc
Copy link
Owner

lxsmnsyc commented Aug 6, 2022

Sorry about that. Yeah I discovered the root of the issue (which is the missing types field), however overwriting typesVersion won't be able to fix it alone since that field is automatically generated. Fear not, I've already fixed it on the bundler-side so I'll push a hotfix immediately. I'll merge this as part of the contribution, thanks!

@lxsmnsyc lxsmnsyc merged commit 86e24cc into lxsmnsyc:main Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants