Action exit code is not set

[lenisha]

Th Lychee action exit code is not reflected in the job

Example run:
https://github.com/lenisha/linkchecker-test/runs/2117110939?check_suite_focus=true

    steps:
      - uses: actions/checkout@v2
      - name: lychee Link Checker
        id: lychee
        uses: lycheeverse/lychee-action@v1.0.4
        with:
          args: --exclude="^(javascript|chrome):.*"   --accept=200,403,429 "**/*.md" "**/*.html"
        env:
          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
      - name: Fail if there were link errors
        run: exit ${{ steps.lychee.outputs.exit_code }}

Although Lychee step exits with status code 2, next steps does not get the exit code properly, it gets 0 instead of 2:

+ lychee '--exclude=^(javascript|chrome):.*' --accept=200,403,429 '**/*.md' '**/*.html' --output /tmp/lychee/out.md
+ exit_code=2
+ '[' 2 -ne 0 ']'
++ dirname lychee/out.md
+ mkdir -p lychee
+ echo 'Errors were reported while checking the availability of links:'
+ cat /tmp/lychee/out.md
+ cat /tmp/lychee/out.md
+ echo ::set-output name=exit_code::2
📝 Summary
---------------------
🔍 Total..........519
✅ Successful.....462
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded........53
🚫 Errors...........4

Errors in python/auto_examples/plot_train_convert_predict.html
✗ https://scikit-learn.org/stable/modules/preprocessing.html/nPlease [404 Not Found]

Errors in docs/reference/execution-providers/Nuphar-ExecutionProvider.md
✗ https://support.microsoft.com/en-us/help/841290 [404 Not Found]

Errors in docs/how-to/build.md
✗ https://cmake.org/files/v3.13/cmake-3.16.1.tar.gz [404 Not Found]
✗ https://www.raspberrypi.org/downloads/raspbian/ [404 Not Found]::set-output name=exit_code::2
1s
Run exit 
  exit 
  shell: /usr/bin/bash -e {0}

[mre]

That's weird. You seem to have done everything correctly... 🤔

[mre]

Tested locally and indeed lychee is exiting with status code 2.

[mre]

Could be something Github actions related maybe? Was there a change recently on how error codes get propagated?

[mre]

The only suspicious thing is that ::set-output didn't begin on a newline.
We recently removed extraneous newlines at the end of the status output, which might be the culprit.
(See lycheeverse/lychee#178)
Added an echo now for a test. Can you try lycheeverse/lychee-action@master and report back?

fyi @pawroman

[lenisha]

yep master with new line works
https://github.com/lenisha/linkchecker-test/runs/2117974486?check_suite_focus=true

[mre]

🎉 thanks for the feedback