added github actions to check broken links

[lakshya8066]

Fixes #357

[Stargator]

I would just looking at one of the following Actions to provide the functionality. I kinda like https://github.com/lycheeverse/lychee-action because it's still active in development. A lot fo the others seemed to have just released one version and forgot about it.

The one you selected, celinekurpershoek/link-checker, hasn't been touched since last October. So I would prefer an active community.

[lakshya8066]

Yeah makes sense, I'll update the pr

[Stargator]

@lakshya8066 Thank you

[Stargator]

Marking this as Hacktoberfest accepted since this is a variable update to our workflow and a great amount of research and testing that goes into it.

[lakshya8066]

Thank you @Stargator :)

[Stargator]

Almost ready, just drop the create issue logic and I think this is good.

[Stargator]

I don't think we need to create an issue as if the Workflow fails, we'd just have the PR branch updated.

[lakshya8066]

Oh okay, I will update the PR

[lakshya8066]

Just to be sure, we don't need the environment variable too right?

[Stargator]

I don't think so.

[Stargator]

@lakshya8066 It seems the Links workflow was not executed. Maybe we do need the secret token?

[lakshya8066]

Right, let's add it and see...

[Stargator]

@lakshya8066 Yep, now the action is running.

[Stargator]

@lakshya8066 It's working, but there is an error for one link and yet the Action seems to be passed as Successful in the PR. I see it is returning exit code 2, is there someway to ensure it fails on error?

[lakshya8066]

@Stargator yes and I believe it stops checking once it gets a broken link or maybe it is just a coincidence.
It was originally supposed to create an issue for the broken link but even without that, tests should fail for non-zero exit codes.
I'm not sure how to achieve this, however, I think this can be helpful. If there is a way to grab the exit code information, we edit the yml to compare the exit codes with 0 and fail the test accordingly. Somethin like this. What do you think?

[Stargator]

@lakshya8066 I made a few updates to resolve some errors. But now it's failing! YAY! 💯

Last steps now:

1. Could you replace all http with https?
2. Update http://exercism.io/languages/dart/help @ErikSchierboom @iHiD, did the help pages get moved? Where should we point users?

[ErikSchierboom]

@Stargator They can be accessed at https://exercism.org/docs/tracks/dart

[Stargator]

@lakshya8066 I am approving this PR and merging it. But, I need you to understand that normally I would require all the checks to pass. That is why I expected the URLs to be fixed in this branch so the new link checker can verify everything is good.

So do understand in the future for this repo or any future repo you contribute to. If there are fixes related to an existing PR it's probably best to do it all in one branch.

Thanks again for all your work and patience, I really appreciate finally having this action in our workflow. 😄 🥇

[lakshya8066]

@Stargator absolutely, I will keep that in mind. I realized the same after creating the other PR.
And thanks for supporting and guiding me through the PR! This was indeed an amazing learning experience. ✨
Looking forward to contributing more to the project :)