Cannot load configuration file: invalid type: integer 200, expected a string

[nvuillam]

Example in documentation contains the following example:

But when using the latest version, we have the following error:

 Error:  Error while loading config: Cannot load configuration file `/github/workspace/.github/linters/lychee.toml`: Failed to parse configuration file
  
  Caused by:
      TOML parse error at line 32, column 11
         |
      32 | accept = [200, 206, 429]
         |           ^^^
      invalid type: integer `200`, expected a string

Out lychee.toml file contains:

# Comma-separated list of accepted status codes for valid links.
accept = [200, 206, 429]

[mre]

Oh, okay. We changed the parsing and status codes need to be strings now. The reason is that ranges are also supported now, e.g. "200..=204". Range syntax is identical to the normal Rust range syntax. We should update the docs to reflect that. Want to send a pull request?
Maybe we could support both, strings and integers, but I don't know how easy that will be.

[nvuillam]

@mre I think the best would be to support both in a 0.14.1 patch, because if after a version upgrade, existing configuration file triggers a crash, it means it's a breaking change, and according to semver, in that case 0.14.0 should have been 1.0.0 :)

[mre]

Supporting both is probably ideal yes.

Just would like to make one small remark that semver allows breaking changes before 1.0. In fact, that's the very reason why lychee is not 1.0 yet: I do anticipate quite a few more breaking changes before the first stable release; it's just that this specific one is probably avoidable. Whether we will support both, string and int, depends on the complexity of the implementation and what side effects this will have down the road. So far I don't see any reason why it shouldn't be possible.

[nvuillam]

Indeed you're right about semver, I forgot the "before 1.0.0 rule" :)

But as lychee is more and more popular (it has been embedded in MegaLinter by a contributor from Microsoft using it on MS internal repos ^^) , projects are more and more dependent on it, maybe it would be time to release a 1.0.0 ? 👼

[Techassi]

We should be able to enable support for single integers and list of integers by widening our custom serde implementation. I could tackle this is a PR in the next few days.

[Techassi]

This will be fixed as soon as #1345 is merged.

[mre]

Amazing work!