Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_mail and exclude_mail flags do not work from config file #1354

Closed
sohailekline opened this issue Jan 23, 2024 · 5 comments · Fixed by #1357
Closed

include_mail and exclude_mail flags do not work from config file #1354

sohailekline opened this issue Jan 23, 2024 · 5 comments · Fixed by #1357

Comments

@sohailekline
Copy link

If we pass include_mail or exclude_mail flags to command in terminal they work as expected. However, if we pass any of these flag in config file (lychee.toml) they do not work. Other configuration are working from config file.

Lychee version = 0.14.1

lychee.toml

exclude_path = [ './node_modules/*' ]
include_mail = true

output

{
  "total": 2,
  "successful": 0,
  "unknown": 0,
  "unsupported": 0,
  "timeouts": 0,
  "redirects": 0,
  "excludes": 1,
  "errors": 1,
  "cached": 0,
  "success_map": {},
  "fail_map": {
    "/Users/.../src/lychee/__tests__/integration/index-spec.md": [
      {
        "url": "https://testingabc.io/",
        "status": {
          "text": "Failed: Network error"
        }
      }
    ]
  },
  "suggestion_map": {},
  "excluded_map": {
    "/Users/.../src/lychee/__tests__/integration/index-spec.md": [
      {
        "url": "mailto:hello-test@testingabc.io",
        "status": {
          "text": "Excluded"
        }
      }
    ]
  },
  "duration_secs": 0,
  "detailed_stats": true
}

Actual:

It is still excluding the emails.

Expected:

It should have checked the email as well and returned that in failed_map.

@mre
Copy link
Member

mre commented Jan 24, 2024

Sorry, that was on oversight on how we merge the commandline flags with the config file. Should be resolved with #1357.

@mre mre closed this as completed in #1357 Jan 24, 2024
@sohailekline
Copy link
Author

@mre Thank you.
When can we expect it be released? At the moment, I am still seeing 0.14.1 as latest version.

@mre
Copy link
Member

mre commented Jan 25, 2024

Hey, I don't have a release date in mind yet. 😅 I would not mind doing a 0.14.2 release soon, though.

@sohailekline
Copy link
Author

That would be so great. I will wait for 0.14.2 release.
Thanks

@mre
Copy link
Member

mre commented Jan 26, 2024

lychee 0.14.2 with the fix is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants