Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend remap feature #1133

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Extend remap feature #1133

merged 2 commits into from
Jul 5, 2023

Conversation

mre
Copy link
Member

@mre mre commented Jul 3, 2023

Extend support for remapping

This adds support for partial remaps and
capture groups to the remap feature.

Fixes #1129

@mre mre force-pushed the remap-ext branch 2 times, most recently from acdf544 to 654852d Compare July 4, 2023 21:55
@mre
Copy link
Member Author

mre commented Jul 4, 2023

@rmoff, can you give that one a shot and report back if it works for you? You'd have to compile lychee from this branch.

@kemingy
Copy link
Contributor

kemingy commented Jul 5, 2023

Hi @mre thanks for this awesome feature. I'm facing a similar issue. I need to remap:

- file:///home/docs/pages/frameworks/mosec
+ file:///home/docs/pages/frameworks/mosec.mdx
# exclude file:///home/docs/pages/frameworks/graph.png

I have verified that this PR works for me.

@rmoff
Copy link

rmoff commented Jul 5, 2023

@mre yes this works perfectly. Thank you!

@mre
Copy link
Member Author

mre commented Jul 5, 2023

Thanks for the feedback. I will update the lychee docs website before I merge this.

This adds supports for partial remaps and
capture groups to the remap feature.

Fixes #1129
@mre mre merged commit 9757312 into master Jul 5, 2023
6 checks passed
@mre mre deleted the remap-ext branch July 5, 2023 13:05
@kemingy
Copy link
Contributor

kemingy commented Aug 8, 2023

Hi @mre, I'm using this feature in the GitHub Actions. It seems the lychee-action doesn't support installation from source or nightly build. Do you mind creating a new release? Thanks a lot.

@mre
Copy link
Member Author

mre commented Aug 8, 2023

Oh, of course. Will do. 👍

@mre
Copy link
Member Author

mre commented Aug 8, 2023

Supporting nightly builds is a great idea. I'd merge that if you want to add it, but I can't remember if we even build nightly versions right now.

@kemingy
Copy link
Contributor

kemingy commented Aug 12, 2023

Supporting nightly builds is a great idea. I'd merge that if you want to add it, but I can't remember if we even build nightly versions right now.

Sure, I will create a PR for the nightly release.

@kemingy kemingy mentioned this pull request Aug 12, 2023
@mre mre added the enhancement New feature or request label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remap - can it rewrite partial URLs?
3 participants