Improve srcset parsing
#1160
Merged
Improve srcset parsing
#1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
State machines are definitely the way to go when writing parsers. I will take a look at the PR asap. |
HU90m
approved these changes
Jul 20, 2023
|
Loved the suggestions. Makes the code quite a bit more idiomatic. Thanks! |
Co-authored-by: Hugo McNally <45573837+HU90m@users.noreply.github.com>
Co-authored-by: Hugo McNally <45573837+HU90m@users.noreply.github.com>
Co-authored-by: Hugo McNally <45573837+HU90m@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current
srcsetparsing is pretty basic.We split on comma and then on whitespace and take the first part, which is the image source URL.
However, we don't handle URLs containing unencoded commas like
/cdn-cgi/image/format=webp,width=640/https://img.youtube.com/vi/hVBl8_pgQf0/maxresdefault.jpg, which leads to false-positives.According to the spec, commas in strings should be encoded, but in practice, there are some websites which don't do that. To handle these cases, too, I propose to extend the
srcsetparsing to make use of a small "state machine", which detects if a comma is within the image source or outside of it while parsing.This is part of an effort to reduce false-positives during link checking.