Decode percent escapes in fragments #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HU90m
force-pushed
the
unicode-fragment
branch
2 times, most recently
from
8160dac
to
1c3e87a
Compare
|
Great. 😊 |
|
I'm pretty certain the failing tests are unrelated. Sorry, for such a slow reply. I kept meaning to find time to fix these failures, but haven't. |
|
A rebase on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Urlstruct percent escapes fragments which breaks checks for titles containing utf8 characters.This PR has a test for this eventuality and a suggested bug fix.