Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test_cookie_jar): use google.com/ncr #1336

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Jan 6, 2024

google.com might redirect to other domains, causing cookie_jar test to fail.

Sample:

builduser@kxxt lychee-0.14.0]$ target/release/lychee "--cookie-jar" jar - <<< "https://google.com"
1/1 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links
🔍 1 Total (in 0s) ✅ 1 OK 🚫 0 Errors
[builduser@kxxt lychee-0.14.0]$ cat jar
{"raw_cookie":"1P_JAR=2024-01-06-04; Secure; Path=/; Domain=google.com; Expires=Mon, 05 Feb 2024 04:44:48 GMT","path":["/",true],"domain":{"Suffix":"google.com"},"expires":{"AtUtc":"2024-02-05T04:44:48Z"}}
{"raw_cookie":"NID=511=GCIi5CLLPHfAgf24gPz2pdzw2eiM-gqKpgG2uplUc3umyqYIkO5llBy-73aJLHZpm9QR1Bw2lArzpMGY10ef0b7VfXj2UB5ravYbpXq7RBR4RefOxx0et6UVc7-4YqcGW9QslF9tpykeF-H4XYyO7pZWioGqAUtP4fe8v-ns3LE; HttpOnly; Path=/; Domain=google.com; Expi
res=Sun, 07 Jul 2024 04:21:33 GMT","path":["/",true],"domain":{"Suffix":"google.com"},"expires":{"AtUtc":"2024-07-07T04:21:33Z"}}
{"raw_cookie":"AEC=Ackid1Ty6bbNpXbnPvPtXeICPFzQ3d_9ZR_W0YgtlYY0vvKRY_YjraxMog; HttpOnly; SameSite=Lax; Secure; Path=/; Domain=google.com; Expires=Thu, 04 Jul 2024 04:21:33 GMT","path":["/",true],"domain":{"Suffix":"google.com"},"expires"
:{"AtUtc":"2024-07-04T04:21:33Z"}}
{"raw_cookie":"1P_JAR=2024-01-06-04; Secure; Path=/; Domain=google.com.hk; Expires=Mon, 05 Feb 2024 04:44:48 GMT","path":["/",true],"domain":{"Suffix":"google.com.hk"},"expires":{"AtUtc":"2024-02-05T04:44:48Z"}}
{"raw_cookie":"AEC=Ackid1SZbLjDy5pIGTzHPV77q080wYaWWvAv5xmAJUBkE_Gq0ErSsRxTgw; HttpOnly; SameSite=Lax; Secure; Path=/; Domain=google.com.hk; Expires=Thu, 04 Jul 2024 04:21:45 GMT","path":["/",true],"domain":{"Suffix":"google.com.hk"},"ex
pires":{"AtUtc":"2024-07-04T04:21:45Z"}}
{"raw_cookie":"NID=511=FzNkCnl29BueXkadoCBkJuFV9eM_cg0rSThNfenjkZ8778a-B-Iy7HeOL5efnUkSTmSiIxMUehpV_uEm5MhgyFUoIPfq824TckqGZjmIk2NMQ7080eUDqyyMuJ-lUJwed49lIQEFeINbF0nH2xYV7C28ddydXu1HiraQfYKOAjTdHW8h4iJ1Zg; HttpOnly; Path=/; Domain=googl
e.com.hk; Expires=Sun, 07 Jul 2024 04:21:45 GMT","path":["/",true],"domain":{"Suffix":"google.com.hk"},"expires":{"AtUtc":"2024-07-07T04:21:45Z"}}

google.com might redirect to other domains, causing cookie_jar test to fail.
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Jan 6, 2024
- Remove upstreamed patch
- Fix test_cookie_jar failure, upstream PR: lycheeverse/lychee#1336
- Update ring fix. Upstream PR to get rid of ring 0.16.20: lycheeverse/lychee#1337
@mre mre merged commit 704126e into lycheeverse:master Jan 6, 2024
7 checks passed
@mre
Copy link
Member

mre commented Jan 6, 2024

Thanks!

felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Jan 7, 2024
- Remove upstreamed patch
- Fix test_cookie_jar failure, upstream PR: lycheeverse/lychee#1336
- Update ring fix. Upstream PR to get rid of ring 0.16.20: lycheeverse/lychee#1337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants