Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic on unknown status codes #246

Merged
merged 3 commits into from Sep 7, 2021
Merged

Don't panic on unknown status codes #246

merged 3 commits into from Sep 7, 2021

Conversation

mre
Copy link
Member

@mre mre commented May 10, 2021

Fixes #234

@pawroman
Copy link
Member

Thinking about it, it's the most reasonable thing to do when we simply don't know what the status code might mean.

Code looks good, too. Nice little PR 👍

@mre mre merged commit e188e72 into master Sep 7, 2021
@mre mre deleted the status-code branch September 7, 2021 23:14
@mre
Copy link
Member Author

mre commented Sep 7, 2021

Finally merged. 🎉

@fauust
Copy link
Contributor

fauust commented Sep 17, 2021

I have just hit this bug, I can confirm that the latest image from docker is correctly handling this:

docker run -it lycheeverse/lychee:0.7.1 --version
lychee 0.7.1docker run -it lycheeverse/lychee:0.7.1 https://mariadb.org
⠂ 129/156 [00:00:00] ████████████████████░░░░░ ✔ https://www.continuent.com/resources/blog/testing-time-and-test-suites-managemen
thread 'tokio-runtime-worker' panicked at 'internal error: entered unreachable code', lychee-lib/src/types/status.rs:73:26docker run -it lycheeverse/lychee:latest --version
lychee 0.7.2docker run -it lycheeverse/lychee:latest https://mariadb.org
📝 Summary
---------------------
🔍 Total..........156
✅ Successful.....151
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
⚠ Unknown..........1
🚫 Errors...........4

@mre
Copy link
Member Author

mre commented Sep 17, 2021

Thanks for the feedback. The only thing that irritates me is that the ⚠️ emoji is not colored in the output. I tried to fix that, but so far no luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle unknown status codes
3 participants