Fix cached 200 status code handling #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert that code 200 never needs to be explicitly accepted for cached response to match the behavior of uncached checks
|
That was quick, many thanks 👍🙂. |
|
There are no artefacts/binaries created until release, right? Give me some minutes to compile it and test. |
|
That's correct. Sorry for the inconvenience. |
|
Works well with this commit 👍. |
MichaIng
approved these changes
Feb 22, 2023
|
Thanks for the test. |
MichaIng
added a commit
to MichaIng/DietPi-Docs
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert that code 200 never needs to be explicitly accepted for cached response
to match the behavior of uncached checks.
Immediately bumps the version to 0.11.1 for the hotfix.
See discussion in #843.