New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter artist details and external links #247

Closed

lydavid opened this issue Jun 24, 2023 · 0 comments

Labels

Owner

lydavid commented Jun 24, 2023

artist details can be filtered via kotlin rather than SQL
Links might be filtered with SQL though

lydavid added the enhancement label

lydavid closed this as completed in

da8e3b6

lydavid pushed a commit that referenced this issue


          feat: filter artist details and external links

866c2a0

since we don't have a paged list flow to work with here, we just pass `filterText` to each item and have them hide themselves
for urls, we can filter them before building a RelationListItem

add missing FakeSpotifyApiService so that test artist image lookup will succeed and test image loader can render a red drawable

use enum class for test tags like Kickstarter: https://github.com/kickstarter/android-oss/blob/44888d815e2c0f5070f19a039fd649bbc844f0bd/app/src/main/java/com/kickstarter/ui/activities/compose/PreLaunchProjectPageScreen.kt#L34
though detekt complains, so we move it to the end of the file, above any previews

resolves #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment