Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Switch from Travis CI to GitHub Actions #21

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Switch from Travis CI to GitHub Actions #21

merged 1 commit into from
Apr 5, 2020

Conversation

andy128k
Copy link
Contributor

@andy128k andy128k commented Apr 2, 2020

No description provided.

@lydell
Copy link
Owner

lydell commented Apr 3, 2020

Nice!

Can you:

@lydell
Copy link
Owner

lydell commented Apr 4, 2020

Can you copy the caching stuff from https://github.com/prettier/eslint-config-prettier/blob/master/.github/workflows/ci.yml as well? Really, you should be able to copy that file as-is to this repo, I think.

@lydell
Copy link
Owner

lydell commented Apr 5, 2020

@andy128k
Copy link
Contributor Author

andy128k commented Apr 5, 2020

@lydell Looks like it never worked. Travis runs tests on Node v13 while here we have 10 and 12 (stable ones).

BTW, Jest fails similarly, but config option "testEnvironment": "node" fixes it.

@lydell
Copy link
Owner

lydell commented Apr 5, 2020

Do you think you can fix it?

@andy128k
Copy link
Contributor Author

andy128k commented Apr 5, 2020

What do you want me to fix? Tape test on node 10.x? Why?

@lydell
Copy link
Owner

lydell commented Apr 5, 2020

I want to merge this. But not if it’s failing. Can you do whatever it takes to make it pass for now? Like disabling something for now, I don’t know. I read this super quickly and don’t understand the problem fully yet.

@andy128k
Copy link
Contributor Author

andy128k commented Apr 5, 2020

The issue is that on Node >= 12 this is false, while on Node 10.x it is true. And string is decoded differently.

I can remove Node 10.x from this action.

@lydell lydell changed the title add GitHub action Switch from Travis CI to GitHub Actions Apr 5, 2020
@lydell lydell merged commit 42b832d into lydell:master Apr 5, 2020
@lydell
Copy link
Owner

lydell commented Apr 5, 2020

Awesome, thanks!

@andy128k andy128k deleted the actions branch April 5, 2020 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants