Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial view of prev and next slide #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lyfeyaj
Copy link
Owner

@lyfeyaj lyfeyaj commented Mar 6, 2015

No description provided.

@lyfeyaj lyfeyaj changed the title add partial display option Add partial view of prev and next slide Mar 6, 2015
@talkhot
Copy link

talkhot commented Jun 20, 2015

Any update on merging this request? Would be a great feature to have in swipe.

@lyfeyaj
Copy link
Owner Author

lyfeyaj commented Jun 21, 2015

@talkhot , yes, it is a great feature. But I have been busy lately, will check it later

@morer
Copy link

morer commented Feb 19, 2016

Hey, I find the slide style is rarely too little, can you give create one like http://www.idangero.us/swiper/demos/06-slides-per-view-auto.html? Thank you for your great work

@agauniyal
Copy link

Could this feature get merged?

@thomas-seres
Copy link

Hi ! Is there any news about merging the feature ?

@peteygao
Copy link

peteygao commented Feb 14, 2017

I just tested the the compiled swipe.min.js on both Firefox 53.0a2 (2017-02-06) and iOS Safari 10.1 and on both browsers, as soon as a swipe is initiated the swiper will continue to swipe without stopping.

EDIT: Just tried the un-compiled version and it also exhibits the same bug.

@arcxyz Speaking of which, the diff is extremely useless as whatever editing tool you used changed the indentation of every single line! Which means that the diff for the ENTIRE file changed, and there's no way to actually review your feature-specific changes. Please revert line-indentation changes for lines that you didn't change so that the diff actually becomes useful.

@rogeralbinoi
Copy link

@peteygao @arcxyz you can code review with ?w=1 param; This ommit identation changes

https://github.com/lyfeyaj/swipe/pull/2/files?w=1

@jack-greenberg
Copy link

Will this feature still be worked on / merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants