Improve hit test methods #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriellanata
force-pushed
the
Improve-hittest-methods
branch
from
3fccaf2
to
0090879
Compare
dduan
previously approved these changes
Jul 15, 2021
gabriellanata
force-pushed
the
Improve-hittest-methods
branch
from
fc77695
to
fbb6569
Compare
dduan
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit testing methods were failing for views with gesture recognizers and for views that only responded to a specific type of event (example: dragging). I'm updating the
screenHitPointto use other methods for detecting if a view is hittable.Additionally, I've also changed the default tap location behavior to return the main view instead of the center point of the screen. By using the view directly we can check if it's actually visible or hittable, resulting in significantly better error messages.