add duo intel module #1172
Merged
add duo intel module #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added other realtionships, jsonof other props add groups, cleanups fix variable name doc update add logs docs test api hosts, groups test endpoints test users fix group test undo lastpass edit undo conftest change
ramonpetgrave64
force-pushed
the
ramonpetgrave64-duo
branch
from
9d92ea3
to
94e5e9d
Compare
achantavy
requested changes
May 12, 2023
| 'user_id': user['user_id'], | ||
| 'username': user['username'], | ||
| 'webauthncredentials': [ | ||
| dumps(webauthncredential) |
There was a problem hiding this comment.
Making sure I understand: this takes the full json and make it a string?
There was a problem hiding this comment.
I guess this is ok for now. Eventually maybe it should be a node but I won't block on this.
There was a problem hiding this comment.
Added. And changed the direction of MEMBER_OF_DUO_GORUP
Co-authored-by: Alex Chantavy <achantavy@lyft.com>
achantavy
reviewed
May 12, 2023
achantavy
reviewed
May 12, 2023
achantavy
requested changes
May 12, 2023
achantavy
reviewed
May 16, 2023
ramonpetgrave64
force-pushed
the
ramonpetgrave64-duo
branch
from
9743df6
to
da9cb02
Compare
achantavy
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Duo intel module