add ec2 keypairs ingestion #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achantavy
requested changes
Aug 8, 2019
achantavy
requested changes
Aug 13, 2019
|
Just an update: we currently have this running in our internal testing setup and will followup when our runs finish |
achantavy
requested changes
Aug 14, 2019
achantavy
requested changes
Aug 15, 2019
* use ARN as Id for EC2KeyPair * add load_ec2_key_pairs test * remove LOGIN_KEY relationship in cleanup jobs * change LOGIN_KEY to SSH_LOGIN_TO * delete proper relationships in cleanup * remove commented dead code * update schema * node merge ARN on both keypair.id and keypair.arn * create index on :EC2KeyPair(id) * remove create index on :EC2KeyPair(arn)
achantavy
approved these changes
Aug 15, 2019
|
Thank you again for your contribution! 😁 |
|
My pleasure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I closed #120, addressed comments from @sachafaust and @achantavy in this PR.
add ec2 keypairs ingestion
use ARN as Id for EC2KeyPair
Ingest EC2 Key Pairs and associate them with EC2 Instances.
Fixes issue #121.