Added support for Azure Storage #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
| storage_account['resourceGroup'], storage_account['name'], | ||
| ).as_dict()['value'] | ||
|
|
||
| except HttpResponseError as e: |
There was a problem hiding this comment.
Just like in #563 , lets catch some specific errors.
There was a problem hiding this comment.
@ramonpetgrave64 Done! :)
|
@ramonpetgrave64 Completed the requested changes and updated code in the branch! :) |
| except ResourceNotFoundError as e: | ||
| logger.warning(f"Storage Account not found error - {e}") | ||
| return [] | ||
| except HttpResponseError as e: |
There was a problem hiding this comment.
I feel we should raise here. If you get the ClientAuthenticationError and ResourceNotFoundError exceptions upon not having proper permissions, then that's fine, we should continue the sync, otherwise, the other failure cases could indicate an incomplete sync.
ramonpetgrave64
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides initial support for Azure Storage resources. It populates resources like Azure Storage Account, Queue Service and Queues, Table Service and Tables, File Service and File Shares, and Blob Service and Blob Containers in the graph DB.