Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GCP asset internet exposure NO_VALUE exception bug #761

Merged
merged 1 commit into from Feb 8, 2022

Conversation

elyst
Copy link
Contributor

@elyst elyst commented Feb 7, 2022

This PR solves Issue 760.

Description:

The GCP asset internet exposure analysis job produced an exception with the following error in on statement #7: ERROR:cartography.graph.job:Unhandled error while executing statement in job 'GCP asset internet exposure': Expected a numeric value but got: NO_VALUE

This was caused by an empty allow_rule.fromport and allow_rule.toport.

@achantavy
Copy link
Contributor

You might need to close and reopen this PR to restart the CLA check

@elyst elyst closed this Feb 7, 2022
@elyst elyst reopened this Feb 7, 2022
@elyst
Copy link
Contributor Author

elyst commented Feb 8, 2022

oh I forgot to sign the CLA, now I did. Sorry for that.

@elyst elyst closed this Feb 8, 2022
@elyst elyst reopened this Feb 8, 2022
@achantavy achantavy merged commit 85764e6 into lyft:master Feb 8, 2022
@achantavy
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants