#758 - Introduce ModuleSyncMetadata node for AWS S3Bucket syncs #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonpetgrave64
changed the title
achantavy
changed the title
achantavy
requested changes
Feb 10, 2022
achantavy
reviewed
Feb 11, 2022
cartography/util.py
Outdated
Comment on lines
71
to
73
| MERGE (n:ModuleSyncMetadata{id:'${group_type}_${group_id}_${synced_type}'}) | ||
| ON CREATE SET n:SyncMetadata, n.firstseen=timestamp() | ||
| SET n.syncedtype='${synced_type}', n.grouptype='${group_type}', n.groupid={group_id}, n.lastupdated={UPDATE_TAG} |
There was a problem hiding this comment.
Suggested change
| MERGE (n:ModuleSyncMetadata{id:'${group_type}_${group_id}_${synced_type}'}) | |
| ON CREATE SET n:SyncMetadata, n.firstseen=timestamp() | |
| SET n.syncedtype='${synced_type}', n.grouptype='${group_type}', n.groupid={group_id}, n.lastupdated={UPDATE_TAG} | |
| MERGE (n:ModuleSyncMetadata{id:'${group_type}_${group_id}_${synced_type}'}) | |
| ON CREATE SET | |
| n:SyncMetadata, | |
| n.firstseen=timestamp() | |
| SET n.syncedtype='${synced_type}', | |
| n.grouptype='${group_type}', | |
| n.groupid={group_id}, | |
| n.lastupdated={UPDATE_TAG} |
achantavy
reviewed
Feb 11, 2022
cartography/util.py
Outdated
| :param neo4j_session: Neo4j session object | ||
| :param group_type: The parent module's type | ||
| :param group_id: The parent module's id | ||
| :param syncd_type: The sub-module's type |
There was a problem hiding this comment.
Suggested change
| :param syncd_type: The sub-module's type | |
| :param synced_type: The sub-module's type |
achantavy
reviewed
Feb 11, 2022
| 'AWS_ID': None, | ||
| 'UPDATE_TAG': None, | ||
| 'OKTA_ORG_ID': None, | ||
| 'AWS_ID': 'my_aw_saccount_id', |
There was a problem hiding this comment.
Suggested change
| 'AWS_ID': 'my_aw_saccount_id', | |
| 'AWS_ID': 'my_aws_account_id', |
achantavy
approved these changes
Feb 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#758 Introduce cartography SyncMetadata node to surface data freshness
add a node
ModuleSyncMetaDatacontaining freshness information for when S3Buckets are synced.