Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backoff to avoid AWS too many requests exception #880

Merged
merged 13 commits into from
Aug 8, 2022
Merged

Add backoff to avoid AWS too many requests exception #880

merged 13 commits into from
Aug 8, 2022

Conversation

rlukin
Copy link
Contributor

@rlukin rlukin commented Jul 11, 2022

Add backoff to avoid AWS too many requests exception
#297
#243
#65
#25

@achantavy
Copy link
Contributor

@rlukin can you sign the CLA?

@rlukin
Copy link
Contributor Author

rlukin commented Jul 16, 2022

@achantavy signed

achantavy
achantavy requested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@achantavy achantavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added quick comment about requirements pinning.

The CI is also being picky and complaining about formatting. If you run make test_lint locally before pushing your branch, it'll fix it and avoid being rejcted

cartography/util.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
achantavy
achantavy previously approved these changes Aug 4, 2022
View reviewed changes
@achantavy achantavy enabled auto-merge (squash) August 4, 2022 06:00
achantavy
achantavy previously approved these changes Aug 4, 2022
View reviewed changes
@achantavy
Copy link
Contributor

Hey @rlukin - can you run make test_lint on your local machine and push back the results? I tried making a few quick edits with the web editor but I keep missing things here and there.

@achantavy achantavy merged commit 98a36bc into lyft:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonpetgrave64 ramonpetgrave64 ramonpetgrave64 approved these changes

@achantavy achantavy achantavy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rlukin @achantavy @ramonpetgrave64