Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redis dependency #12

Closed
ryan-lane opened this issue Sep 17, 2015 · 3 comments
Closed

Remove redis dependency #12

ryan-lane opened this issue Sep 17, 2015 · 3 comments

Comments

@ryan-lane
Copy link
Contributor

We should be able to handle sessions and auth without redis, especially since it's the only place we're using it.

@ab
Copy link
Contributor

ab commented Mar 23, 2016

Do you have thoughts on what's involved here? I got pretty far along with Flask's native cookie-based sessions, but ran into issues with the XSRF-TOKEN not being saved on the session by the XHR request to /v1/user/email.

@damaestro
Copy link

This would be an awesome feature. Maybe using stateless JWT? (warning: other security implications here)

@ryan-lane
Copy link
Contributor Author

Fixed in ab8bc60. This uses Flask secure cookies, with a lifetime and max lifetime setting. Users get a permanent cookie that has expiration defined in the session. When users do actions in the interface they get their expiration time updated. The session can only be extended up to the maximum session lifetime. This makes it possible to limit session lifetimes to a relatively short period of time (like 1 hour), with a longer maximum lifetime (like 24 hours). Redis is still there for those who want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants