Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace environment variable for configuration injection #135

Closed
tweise opened this issue Nov 24, 2019 · 4 comments
Closed

Replace environment variable for configuration injection #135

tweise opened this issue Nov 24, 2019 · 4 comments

Comments

@tweise
Copy link
Contributor

tweise commented Nov 24, 2019

Environment variable OPERATOR_FLINK_CONFIG should be replaced with FLINK_PROPERTIES to support the stock Flink Docker images.

docker-flink/docker-flink#82

We should also update the example to use that image.

tweise added a commit to tweise/flinkk8soperator that referenced this issue Nov 25, 2019
tweise added a commit to tweise/flinkk8soperator that referenced this issue Nov 27, 2019
@tweise
Copy link
Contributor Author

tweise commented Dec 4, 2019

Environment variable substitution merged upstream: docker-flink/docker-flink#91

@mwylde
Copy link
Contributor

mwylde commented Dec 4, 2019

Is there a way we can make this backwards compatible? Otherwise this will break people's existing images.

@tweise
Copy link
Contributor Author

tweise commented Dec 4, 2019

Yes, unfortunately it would break images if they were copied from the previous example. On the other hand, the operator will become compatible with the docker-flink images and custom cruft can just be deleted. Should we publish both environment variables for a while or just switch before going out of beta?

@mwylde
Copy link
Contributor

mwylde commented Dec 5, 2019

Yeah, I think we would need to do something along those lines. Otherwise this is a breaking change that will be hard to manage for users.

tweise added a commit to tweise/flinkk8soperator that referenced this issue Dec 21, 2019
tweise added a commit to tweise/flinkk8soperator that referenced this issue Dec 21, 2019
tweise added a commit to tweise/flinkk8soperator that referenced this issue Dec 21, 2019
tweise added a commit to tweise/flinkk8soperator that referenced this issue Dec 23, 2019
@tweise tweise closed this as completed in 2a5baaf Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants