Gate statemachine progress on taskmanager availability #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
requested review from
anandswaminathan,
glaksh100 and
kumare3
as code owners
| if !ready { | ||
|
|
||
| // ignore the error, we just care whether it's ready or not | ||
| serviceReady, _ := s.flinkController.IsServiceReady(ctx, application, flink.HashForApplication(application)) |
There was a problem hiding this comment.
Since you do this here, you do not need to check IsServiceReady check in SubmittingJob state right?
There was a problem hiding this comment.
Yeah, that check is probably not necessary any more
There was a problem hiding this comment.
Removed the check in SubmittingJob
added 6 commits
December 13, 2019 13:38
mwylde
force-pushed
the
micah_better_job_health
branch
from
129eb39
to
8f07929
Compare
| @@ -155,6 +155,9 @@ type FlinkJobStatus struct { | |||
| RestorePath string `json:"restorePath,omitempty"` | |||
| RestoreTime *metav1.Time `json:"restoreTime,omitempty"` | |||
| LastFailingTime *metav1.Time `json:"lastFailingTime,omitempty"` | |||
|
|
|||
| RunningTasks int32 `json:"runningTasks,omitempty"` | |||
| TotalTasks int32 `json:"totalTasks,omitempty"` | |||
There was a problem hiding this comment.
This is what golangci-lint --fix produces. I think it only aligns stuff if there is no line break (see other examples in this file for similar formatting).
anandswaminathan
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only condition for moving from ClusterStarting to Savepointing (at which point the job goes down) is that all JM/TM pods are up according to the deployment. However, various issues with the TM process or configuration can prevent them from actually registering with the JobManager and becoming available to run tasks. This can lead to extended downtime and can require manual intervention to fix. I've also added a check from the SubmittingJob -> Running transition that the tasks are actually running, which gives us a chance to automatically roll back if the job never successfully starts.
This PR also adds some more visibility into task-level status, so that users can tell if the job is really running (in Flink, a job can be in the Running state even if none of its tasks are running). I've added two new fields to the JobStatus (TotalTasks and RunningTasks) and updated the JobHealth logic to take into account whether tasks are actually running.