Enabling PodSecurityContext to be configured for JM and TM pod templates #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager pods * Updating the CRD to enable pod security context to be specified and applied to JM and TM pods. * Adding security context fields to crd validation. * Changing security context injection to maintain hash-based backwards compatibility. * Adding tests to ensure that security context is being injected properly.
kelly-sm
requested review from
anandswaminathan,
glaksh100,
kumare3 and
mwylde
as code owners
|
+1 LGTM |
|
Is there a way to pull an image of this once it is merged in? Does each commit get built and pushed somewhere? |
|
@kelly-sm Once you merge. We have Travis that will automatically build and push the image. You can then pull the image from |
|
@anandswaminathan sounds good. Sounds like we just need another person to review/approve? Thanks! |
anandswaminathan
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the CRD to enable pod security context to be specified and applied to JM and TM pods.
Adding security context fields to crd validation.
Changing security context injection to maintain hash-based backwards compatibility.
Adding tests to ensure that security context is being injected properly.