[STRMCMP-844] Fix rollback when SubmittingJob times out #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
requested review from
anandswaminathan,
glaksh100 and
kumare3
as code owners
| @@ -460,6 +460,7 @@ func (s *FlinkStateMachine) handleSubmittingJob(ctx context.Context, app *v1beta | |||
| // Something's gone wrong; roll back | |||
| s.flinkController.LogEvent(ctx, app, corev1.EventTypeWarning, "JobSubmissionFailed", | |||
| fmt.Sprintf("Failed to submit job: %s", reason)) | |||
| app.Status.JobStatus.JobID = "" | |||
There was a problem hiding this comment.
Want to add a small unit test?
|
Added a test |
glaksh100
approved these changes
Feb 28, 2020
anandswaminathan
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we time out after the new job has been submitted (generally because the tasks are never all running, possibly due to parallelism being misconfigured), we will enter the rollback phase. However, because the new job was submitted, the jobID is set in our status, and so [this check|https://github.com/lyft/flinkk8soperator/blob/4142437353666b8692e62acf075a9b2c70514dd9/pkg/controller/flinkapplication/flink_state_machine.go#L396] prevents us from submitting the job to the old cluster.
This PR fixes that issue by clearing the jobId before moving to the RollingBack phase.