Fix regression in handling of default heap memory config #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
requested review from
anandswaminathan,
glaksh100 and
kumare3
as code owners
added 2 commits
November 13, 2020 09:37
glaksh100
reviewed
Nov 16, 2020
| } else { | ||
| (*config)["jobmanager.memory.process.size"] = getJobManagerMemory(app) | ||
| (*config)["taskmanager.memory.process.size"] = getTaskManagerMemory(app) | ||
| // if heap memory is used for >= 1.11, error out |
There was a problem hiding this comment.
Not intended to be solved in this PR, but I'm wondering if we can support various flink version --> config compatibility in a different way than if .. else blocks. I guess one way could be to couple operator versions to flink versions, but that seems a bit restrictive.
There was a problem hiding this comment.
I don't think we would want to couple operator versions to flink versions, as most deployments will likely be heterogenous (currently at Lyft we have the operator managing applications with Flink 1.9, 1.10, and 1.11).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #207 which caused us to use the wrong default for heap memory configs in Flink <1.11.
It also simplifies the memory configuration situation a bit. Now, for Flink <1.11 you may only configure memory with the existing
offHeapMemoryFraction(which translates intojobmanager.heap.size/taskmanager.heap.size) and for version >= 1.11 you may only use the newsystemMemoryFraction(which translates tojobmanager.memory.process.size/taskmanager.memory.process.size). Using an incompatible configuration for the specifiedflinkVersionwill produce an error.