Adding openAPIV3Schema Validation for the Flink application custom resource #33
Conversation
anandswaminathan
requested review from
glaksh100,
kumare3 and
mwylde
as code owners
deploy/crd.yaml
Outdated
| enum: [Savepoint, None, ForceCancel] | ||
| deploymentMode: | ||
| type: string | ||
| enum: [Single, Dual] |
There was a problem hiding this comment.
Since Single is not currently supported, should we remove?
| type: object | ||
| properties: | ||
| additionalProperties: | ||
| type: string |
There was a problem hiding this comment.
I think this is too restrictive. In the go definition this is map[string]interface{}, and there are flink configs that are numeric and boolean in addition to string.
There was a problem hiding this comment.
The problem with map[string]interface{} is that it can allow nested structure. On the other end we are appending only strings to the conf.yaml.
I tested with integer values like taskmanager.heap.size: 200 and boolean values and they work. It integer as numeric string and does not fail.
| properties: | ||
| additionalProperties: | ||
| type: string | ||
| envConfig: |
There was a problem hiding this comment.
Can we factor this out into its own object? That would avoid the need to duplicate it between TM/JM.
There was a problem hiding this comment.
I tried that I am unable to make components work for custom resources. Do you have any working example you can share ?
There was a problem hiding this comment.
Looks like it's not supported in kubernetes: kubernetes/kubernetes#62872 😞
Adding Validation of flink application custom objects using openAPIV3Schema. Helps fail the creation/update of custom resources with invalid format.