Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no data in Presto (#8268) #71

Merged
merged 1 commit into from Sep 30, 2019

Conversation

betodealmeida
Copy link

We have a bug in prod where if no data is returned in Presto an exception is raised. apache#8268 fixes it, but bringing it causes a major conflict due to apache#8258.

This PR cherry-picks apache#8268 to fix the problem, while we figure out how to handle the deck.gl migration to NPM.

馃憖 @DiggidyDave

* Fix no data in Presto

* Fix test
@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #71 into lyft-master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           lyft-master      #71   +/-   ##
============================================
  Coverage        64.75%   64.75%           
============================================
  Files              490      490           
  Lines            23855    23855           
  Branches          2630     2630           
============================================
  Hits             15448    15448           
  Misses            8254     8254           
  Partials           153      153
Impacted Files Coverage 螖
superset/dataframe.py 94.48% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 60f11fd...0717f65. Read the comment docs.

Copy link

@DiggidyDave DiggidyDave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Beto and I discussed, I'm ok with this to unblock people as long as getting the actual fix in the P0 priority, so that we don't end up with an additional long-lived private change downstream of apache.

@betodealmeida
Copy link
Author

馃殌

@betodealmeida betodealmeida merged commit 853e157 into lyft:lyft-master Sep 30, 2019
@mistercrunch mistercrunch deleted the fix_array_no_data branch March 25, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants