Handle cached containers that are stopped #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jordan is the "other guy" I was talking about in issue #19 👍 |
|
Hey @jordanrasmussen, this looks great. Before I can merge this in, you'll need to sign our CLA, which can be signed here: https://oss.lyft.com/cla/#/signature Thanks for sending in a PR! |
|
@ryan-lane, CLA has been signed. |
|
Cool. I'm doing a bit of quick manual testing here first, then I'll merge it in. |
|
Nice work! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #19
This change checks to see if the cached container is running and if its not, removes it from the cache.
This will 1, prevent returning the role for the last container that had it's ip address and 2 help keep the cache clean of stopped containers.