Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile cleanup #117

Merged
merged 2 commits into from
Mar 14, 2023
Merged

makefile cleanup #117

merged 2 commits into from
Mar 14, 2023

Conversation

jcapote-lyft
Copy link
Collaborator

  • remove vendor and glide from Makefile
  • remove glide link from readme

@jcapote-lyft jcapote-lyft changed the title cleanup makefile cleanup Mar 14, 2023
crockeo
crockeo approved these changes Mar 14, 2023
View reviewed changes
Copy link

@crockeo crockeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming that this should be it:

~/src/protoc-gen-star$ ag glide
Makefile
88:     which glide || (curl https://glide.sh/get | sh)
89:     glide install

README.md
363:[glide]: http://glide.sh

@jcapote-lyft jcapote-lyft merged commit eb33464 into master Mar 14, 2023
@jcapote-lyft jcapote-lyft deleted the cleanup branch March 14, 2023 21:05
@jcapote-lyft
Copy link
Collaborator Author

yep thats what i forgot to do the first time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crockeo crockeo crockeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcapote-lyft @crockeo