Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Fix leaking child scopes through parent children collection #52

Merged
merged 2 commits into from
Mar 23, 2016

Conversation

lexer
Copy link
Contributor

@lexer lexer commented Mar 23, 2016

  1. Child get removed, but was not removed from parent children hashmap
  2. We don't need to remove reference from child to parent. (It won't create leak)
  3. We don't need to clean services. (It won't create leak)

@itspbj
Copy link
Contributor

itspbj commented Mar 23, 2016

👍

@itspbj itspbj merged commit d3bc00e into master Mar 23, 2016
@itspbj itspbj deleted the scoop-leaking-fix branch March 23, 2016 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants